Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add broker address in broker rpc error message #46085

Merged
merged 2 commits into from
Aug 8, 2024
Merged

[Enhancement] Add broker address in broker rpc error message #46085

merged 2 commits into from
Aug 8, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented May 23, 2024 •
edited
Loading

Why I'm doing:

*************************** 3. row ***************************
         JobId: 10149
         Label: label01
         State: CANCELLED
      Progress: ETL:N/A; LOAD:N/A
          Type: BROKER
      Priority: NORMAL
      ScanRows: 0
  FilteredRows: 0
UnselectedRows: 0
      SinkRows: 0
       EtlInfo: NULL
      TaskInfo: resource:N/A; timeout(s):14400; max_filter_ratio:0.0
      ErrorMsg: type:LOAD_RUN_FAIL; msg:No broker permission, java.io.IOException: ERROR: not found login secrets, please configure the accessKeyId and accessKeySecret., cause by: ERROR: not found login secrets, please configure the accessKeyId and accessKeySecret.
    CreateTime: 2024-05-22 20:18:58
  EtlStartTime: 2024-05-22 20:18:59
 EtlFinishTime: 2024-05-22 20:18:59
 LoadStartTime: 2024-05-22 20:18:59
LoadFinishTime: 2024-05-22 20:18:59
   TrackingSQL:
    JobDetails: {"All backends":{"b32340bf-9a2f-4848-993f-27d35250b519":[10002]},"FileNumber":1,"FileSize":96,"InternalTableLoadBytes":0,"InternalTableLoadRows":0,"ScanBytes":0,"ScanRows":0,"TaskNumber":1,"Unfinished backends":{"b32340bf-9a2f-4848-993f-27d35250b519":[]}}

What I'm doing:

*************************** 5. row ***************************
         JobId: 10157
         Label: label01
         State: CANCELLED
      Progress: ETL:N/A; LOAD:N/A
          Type: BROKER
      Priority: NORMAL
      ScanRows: 0
  FilteredRows: 0
UnselectedRows: 0
      SinkRows: 0
       EtlInfo: NULL
      TaskInfo: resource:N/A; timeout(s):14400; max_filter_ratio:0.0
      ErrorMsg: type:LOAD_RUN_FAIL; msg:No broker permission, error=java.io.IOException: ERROR: not found login secrets, please configure the accessKeyId and accessKeySecret., cause by: ERROR: not found login secrets, please configure the accessKeyId and accessKeySecret., broker=127.0.0.1
    CreateTime: 2024-05-23 00:24:00
  EtlStartTime: 2024-05-23 00:24:03
 EtlFinishTime: 2024-05-23 00:24:03
 LoadStartTime: 2024-05-23 00:24:03
LoadFinishTime: 2024-05-23 00:24:04
   TrackingSQL:
    JobDetails: {"All backends":{"624698f5-f335-455e-a6d9-03ab7b532bd2":[10002]},"FileNumber":1,"FileSize":96,"InternalTableLoadBytes":0,"InternalTableLoadRows":0,"ScanBytes":0,"ScanRows":0,"TaskNumber":1,"Unfinished backends":{"624698f5-f335-455e-a6d9-03ab7b532bd2":[]}}

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner May 23, 2024 01:40
@mergify mergify bot assigned wyb May 23, 2024
kevincai
kevincai previously approved these changes Jul 23, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

[BE Incremental Coverage Report]

❌ fail : 11 / 49 (22.45%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/fs/fs_broker.cpp 11 49 22.45% [63, 65, 67, 68, 70, 71, 73, 74, 76, 77, 81, 82, 84, 85, 87, 98, 99, 119, 123, 146, 177, 181, 182, 236, 240, 241, 242, 300, 329, 367, 381, 386, 387, 388, 406, 443, 521, 526]

@wanpengfei-git wanpengfei-git merged commit 5708243 into StarRocks:main Aug 8, 2024
49 of 50 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

@Mergifyio backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 8, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@wyb @mergify
[Enhancement] Add broker address in broker rpc error message (#46085)
8b8dd95 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 5708243)
@mergify mergify bot mentioned this pull request Aug 8, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@wyb @mergify
[Enhancement] Add broker address in broker rpc error message (#46085)
08bf804 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 5708243)
@mergify mergify bot mentioned this pull request Aug 8, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Aug 8, 2024
@wyb @mergify
[Enhancement] Add broker address in broker rpc error message (#46085)
b7a252e 
Signed-off-by: wyb <[email protected]>
(cherry picked from commit 5708243)
@mergify mergify bot mentioned this pull request Aug 8, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @wyb
[Enhancement] Add broker address in broker rpc error message (backport …
9560005 
…#46085) (#49604)

Co-authored-by: wyb <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @wyb
[Enhancement] Add broker address in broker rpc error message (backport …
af95d87 
…#46085) (#49605)

Co-authored-by: wyb <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @wyb
[Enhancement] Add broker address in broker rpc error message (backport …
fbad870 
…#46085) (#49606)

Co-authored-by: wyb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@jaogoy jaogoy jaogoy approved these changes

@meegoo meegoo meegoo approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@wyb wyb

Labels
3.1-merged 3.2-merged 3.3-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wyb @kevincai @meegoo @jaogoy @wanpengfei-git